HTML API: Reconsume script data terminating less-than tokens#12184
HTML API: Reconsume script data terminating less-than tokens#12184sirreal wants to merge 6 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This was a parsing bug, not a serialization bug. Remove the serialization tests.
dmsnell
left a comment
dmsnell
left a comment
There was a problem hiding this comment.
Great catch; was this brought up via fuzzing?
|
Yes! HTML API fuzz tests caught this. |
Address edge cases where SCRIPT tag closers were not detected and the processor remained paused on an incomplete token. Developed in #12184. Props jonsurrell, dmsnell. See #65372. git-svn-id: https://develop.svn.wordpress.org/trunk@62509 602fd350-edb4-49c9-b593-d223f7449a82
|
Merged in r62509. |
Address edge cases where SCRIPT tag closers were not detected and the processor remained paused on an incomplete token. Developed in WordPress/wordpress-develop#12184. Props jonsurrell, dmsnell. See #65372. Built from https://develop.svn.wordpress.org/trunk@62509 git-svn-id: http://core.svn.wordpress.org/trunk@61790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2 participants
Summary
When a
<script>tag terminated with<or<\, the parser would skip the next token. This would make HTML like<script><</script>appear as an incomplete token (a SCRIPT tag with no closer) to the Tag Processor.Inputs like
<script><</script>or<script>whatever… <</script>would fail to parse at an incomplete token.Trac ticket: https://core.trac.wordpress.org/ticket/65372
Testing
Use of AI Tools
AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5.5
Used for: PR description cleanup and code review.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.